This repository was archived by the owner on Jun 19, 2023. It is now read-only.
Add support for server-side encryption #139
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 14, 2019 12:40
jeskew
reviewed
Jan 30, 2019
| StreamSpecification: streamViewType === 'NONE' | ||
| ? { StreamEnabled: false } | ||
| : { StreamEnabled: true, StreamViewType: streamViewType }, | ||
| SSESpecification: sseSpecification.enabled |
Contributor
There was a problem hiding this comment.
Is there a use case where someone might change their SSE settings but not enable it? Could this instead check if sseSpecification is defined?
Contributor
Author
|
At this time, this PR is behind from current master. |
Contributor
|
Closing in favor of #147 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow you to create table with server-side encryption.