Switch to use daemonset deployment for image preload #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdu31
changed the title
xdu31
force-pushed
the
perf-tests-fork
branch
2 times, most recently
from
8814b48 to
4d33ace
Compare
mengqiy
reviewed
Jul 23, 2025
| image: {{.PodImage}} | ||
| resources: | ||
| requests: | ||
| cpu: "120m" |
Contributor
There was a problem hiding this comment.
Let's reduce request 10m and 10Mi. Then remove limit
mengqiy
reviewed
Jul 23, 2025
| @@ -0,0 +1,394 @@ | |||
| apiVersion: tekton.dev/v1 | |||
Contributor
There was a problem hiding this comment.
awscli-cl2-load-with-addons-slos.yaml.orig?
mengqiy
reviewed
Jul 23, 2025
Contributor
mengqiy
left a comment
mengqiy
left a comment
There was a problem hiding this comment.
For posterity, it'd be helpful to include why we change it to embeded DS instead of using node-preload-images in the PR description.
mengqiy
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Switch to use daemonset deployment for image preload
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.