add dataplane webhooks and fix dp finalizer #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwagner5
requested review from
JacobGabrielson,
ellistarn,
hakuna-matatah and
prateekgogia
as code owners
prateekgogia
approved these changes
Nov 22, 2021
Contributor
prateekgogia
left a comment
prateekgogia
left a comment
There was a problem hiding this comment.
Nicely done! LGTM!
Fixes #72
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
allocationStrategywas not set and not defaulted since the webhooks weren't wired up), the finalizer would fail since the ASG deletion would error. It now checks if the ASG exists before trying to delete it.make applyandmake deleteuse the templated helm chart now. And CRDs are in the proper directory now.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.