Skip to content

Conversation

@tomerd
Copy link
Contributor

@tomerd tomerd commented Jul 1, 2020

motivation: clearer guidelines for using the example

changes: fix a few typos, fix incorrect scheme name and add a bit more prose

motivation: clearer guidelines for using the example

changes: fix a few typos, fix incorrect scheme name and add a bit more prose
@tomerd tomerd requested review from fabianfett, ktoso and yim-lee July 1, 2020 23:11
@tomerd tomerd added the 🔨 semver/patch No public API change. label Jul 1, 2020
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Yim Lee <yim_lee@apple.com>
Copy link
Contributor

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomerd tomerd merged commit b8834b2 into master Jul 2, 2020
@tomerd tomerd deleted the tomerd-patch-1-1 branch October 5, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔨 semver/patch No public API change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants