Skip to content

Conversation

@tomerd
Copy link
Contributor

@tomerd tomerd commented Aug 6, 2020

motivation: nicer error messages

changes: return 405 when using wrong http method on the lambda invocatoin endpoint (local debug server)

… http method

motivation: nicer error messages

changes: return 405 when using wrong http method on the lambda invocatoin endpoint (local debug server)
@tomerd tomerd requested a review from fabianfett August 6, 2020 21:35
@tomerd
Copy link
Contributor Author

tomerd commented Aug 6, 2020

closes #146

@fabianfett @helje5 this is a minimal fix for the most common issue which @helje5 ran into. I agree with @fabianfett idea of addressing more broadly by separating the external facing server and the internal one

@tomerd tomerd linked an issue Aug 6, 2020 that may be closed by this pull request
Copy link
Contributor

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomerd
Copy link
Contributor Author

tomerd commented Aug 6, 2020

5.3 failure is due to swift-format, can ignore for now

@tomerd tomerd merged commit f3c68d6 into awslabs:master Aug 6, 2020
@tomerd tomerd added this to the 0.3.0 milestone Aug 6, 2020
@tomerd tomerd added the 🔨 semver/patch No public API change. label Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔨 semver/patch No public API change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

404 on a GET even though resource URL is valid for a POST

2 participants