Skip to content

SNS MessageAttributes are optional #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2021
Merged

SNS MessageAttributes are optional #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac8bd3d
MessageAttributes are optional
dwaynecoussement-lgtm Jun 4, 2021
cef771c
Remove tabs
dwaynecoussement-lgtm Jun 4, 2021
4be1436
Merge branch 'main' into sns-attributes-optional
tomerd Jun 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/AWSLambdaEvents/SNS.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public enum SNS {
public let messageId: String
public let type: String
public let topicArn: String
public let messageAttributes: [String: Attribute]
public let messageAttributes: [String: Attribute]?
public let signatureVersion: String

@ISO8601WithFractionalSecondsCoding
Expand Down
6 changes: 3 additions & 3 deletions Tests/AWSLambdaEventsTests/SNSTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@ class SNSTests: XCTestCase {
XCTAssertEqual(record.sns.signingCertURL, "https://sns.eu-central-1.amazonaws.com/SimpleNotificationService-6aad65c2f9911b05cd53efda11f913f9.pem")
XCTAssertEqual(record.sns.unsubscribeUrl, "https://sns.eu-central-1.amazonaws.com/?Action=Unsubscribe&SubscriptionArn=arn:aws:sns:eu-central-1:079477498937:EventSources-SNSTopic-1NHENSE2MQKF5:6fabdb7f-b27e-456d-8e8a-14679db9e40c")

XCTAssertEqual(record.sns.messageAttributes.count, 2)
XCTAssertEqual(record.sns.messageAttributes?.count, 2)

XCTAssertEqual(record.sns.messageAttributes["binary"], .binary([UInt8]("base64".utf8)))
XCTAssertEqual(record.sns.messageAttributes["string"], .string("abc123"))
XCTAssertEqual(record.sns.messageAttributes?["binary"], .binary([UInt8]("base64".utf8)))
XCTAssertEqual(record.sns.messageAttributes?["string"], .string("abc123"))
}
}