Adopt concurrency adoption guidelines #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
6 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
stevapple
force-pushed
the
concurrency-guideline
branch
3 times, most recently
from
b91487c to
a844d9e
Compare
stevapple
force-pushed
the
concurrency-guideline
branch
2 times, most recently
from
035c5ef to
0a0d1aa
Compare
fabianfett
approved these changes
Dec 6, 2021
|
@swift-server-bot test this please |
|
@stevapple Let's do the sendable checks in another pr please! We don't mind them for merging right now. |
stevapple
force-pushed
the
concurrency-guideline
branch
from
8af643e to
a63cda6
Compare
stevapple
force-pushed
the
concurrency-guideline
branch
from
a63cda6 to
b78e4a0
Compare
|
@swift-server-bot test this please (@tomerd @yim-lee could I get bot rights for this repo and lambda-events as well please?) |
@fabianfett I believe you have them already. Are you experiencing issues? |
|
Nightly failed because of Sendable checking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt Swift Concurrency adoption guidelines for Swift Server Libraries (swift-server/guides#70).
Motivation:
Adopt Swift Concurrency adoption guidelines (for the correct way to import
_Concurrency).Modifications:
#if compiler(>=5.5) && canImport(_Concurrency)to judge if Concurrency is available;