Add ControlPlaneRequestEncoder #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
force-pushed
the
ff-request-encoder
branch
from
c31cd9e to
af3e1c1
Compare
tomerd
reviewed
Dec 10, 2021
| self.byteBuffer.writeString(.userAgentHeader) | ||
| self.byteBuffer.writeContentLengthHeader(length: contentLength) | ||
| self.byteBuffer.writeString(.CRLF) // end of head | ||
| if contentLength > 0 { |
There was a problem hiding this comment.
if let payload = payload && contentLength > 0 could be nice so we can drop the force unwrap
tomerd
reviewed
Dec 10, 2021
|
|
||
| mutating func writerAdded(context: ChannelHandlerContext) { | ||
| self.byteBuffer = context.channel.allocator.buffer(capacity: 256) | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
ControlPlaneRequestEncoderthat encodes all requests into an existing buffer.Motivation:
We want to write our request to the ControlPlaneAPI into one buffer, that we can reuse over and over.
Modifications:
ControlPlaneRequestEncoderthat writesControlPlaneRequests into a buffer that is reused.Result: