Skip to content

Conversation

gestrich
Copy link
Contributor

@gestrich gestrich commented May 8, 2022

This adds brief notes on building from an M1 as I don't believe the samples will work without special adjustments.

Motivation:

I had spent a few days attempting to build from my M1 but was a bit confused as to what was wrong. It turned out to be a very simple fix.

Modifications:

Update the Deployment documentation so that M1 users quickly know they need to make some adjustments before spending time trying to deploy the samples.

Result:

Hopefully more users on M1s will be able to deploy the samples.

@swift-server-bot
Copy link

Can one of the admins verify this patch?

14 similar comments
@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

```

Note: The example scripts assume you have [jq](https://stedolan.github.io/jq/download/) command line tool installed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This information seems to apply to all types of deployments here (CLI, SAM, Serverless) so I made a special section for it. For an M1 user, this information is really critical.

@tomerd
Copy link
Contributor

tomerd commented May 9, 2022

@swift-server-bot test this please

@tomerd tomerd merged commit 20978cc into awslabs:main May 9, 2022
@tomerd
Copy link
Contributor

tomerd commented May 9, 2022

thank you @gestrich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants