Skip to content

[plugin] Use LAMBDA_USE_LOCAL_DEPS env var in local builds with docker #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2024
Merged

[plugin] Use LAMBDA_USE_LOCAL_DEPS env var in local builds with docker #325

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2af6e1
Use LAMBDA_USE_LOCAL_DEPS env var in local builds with docker
sebsto May 13, 2024
8001cff
Merge branch 'main' into sebsto/use_local_deps
sebsto May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions Plugins/AWSLambdaPackager/Plugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,24 @@ struct AWSLambdaPackager: CommandPlugin {
for product in products {
print("building \"\(product.name)\"")
let buildCommand = "swift build -c \(buildConfiguration.rawValue) --product \(product.name) --static-swift-stdlib"
try self.execute(
executable: dockerToolPath,
arguments: ["run", "--rm", "-v", "\(packageDirectory.string):/workspace", "-w", "/workspace", baseImage, "bash", "-cl", buildCommand],
logLevel: verboseLogging ? .debug : .output
)
if ProcessInfo.processInfo.environment["LAMBDA_USE_LOCAL_DEPS"] != nil {
// when developing locally, we must have the full swift-aws-lambda-runtime project in the container
// because Examples' Package.swift have a dependency on ../..
// just like Package.swift's examples assume ../.., we assume we are two levels below the root project
let lastComponent = packageDirectory.lastComponent
let beforeLastComponent = packageDirectory.removingLastComponent().lastComponent
try self.execute(
executable: dockerToolPath,
arguments: ["run", "--rm", "--env", "LAMBDA_USE_LOCAL_DEPS=true", "-v", "\(packageDirectory.string)/../..:/workspace", "-w", "/workspace/\(beforeLastComponent)/\(lastComponent)", baseImage, "bash", "-cl", buildCommand],
logLevel: verboseLogging ? .debug : .output
)
} else {
try self.execute(
executable: dockerToolPath,
arguments: ["run", "--rm", "-v", "\(packageDirectory.string):/workspace", "-w", "/workspace", baseImage, "bash", "-cl", buildCommand],
logLevel: verboseLogging ? .debug : .output
)
}
let productPath = buildOutputPath.appending(product.name)
guard FileManager.default.fileExists(atPath: productPath.string) else {
Diagnostics.error("expected '\(product.name)' binary at \"\(productPath.string)\"")
Expand Down