Skip to content

Conversation

aryan-25
Copy link
Contributor

Motivation:

  • This PR paves the way to land the new API discussed in v2 API Proposal Document #339.
  • AWS Lambda Runtime v2 will require Swift 6 as it will enforce full Sendability checking.
  • For us to land the PRs that work towards our new API, we need to require Swift 6.

Modifications:

  • Change swift-tools-version from 5.9 to 6.0 in Package.swift.
  • Use Swift 5 Language Mode for all targets.
  • Modify Plugin.swift to compile error-free with Swift 6.

Result:

First step towards adopting Swift 6.

@fabianfett
Copy link
Contributor

@swift-server-bot add to whitelist

@fabianfett fabianfett requested a review from sebsto August 23, 2024 11:56
Copy link
Collaborator

@sebsto sebsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabianfett
Copy link
Contributor

Let's land #340 and then rebase on top of it.

Copy link
Contributor

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Let's get CI in order

@fabianfett
Copy link
Contributor

API breakage and doc check fail because of 5.10 requirement. Merging to unblock further work for now. Will enforce at a later point in time again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants