Skip to content

Conversation

sebsto
Copy link
Collaborator

@sebsto sebsto commented Oct 20, 2025

Fix errors in the CI
The script that checks the presence of libFoundation in the binary started to fail.
I can't think about a recent change that would cause this.

This PR change the test script to use the HelloWorld example instead of APIGAtewayV2

@sebsto sebsto added the 🔨 semver/patch No public API change. label Oct 20, 2025
@sebsto sebsto self-assigned this Oct 20, 2025
@sebsto
Copy link
Collaborator Author

sebsto commented Oct 20, 2025

The HelloWorld example doesn't link with Foundation, which makes me think the dependency might be imported by swift-lambda-events library, although I can't find any trace of libFoundation in its binary.

bash-4.2# nm Examples/APIGatewayV2/.build/release/APIGatewayLambda | grep -i NSURL
                 U $s10Foundation5NSURLC6string10relativeToACSgSS_0A10Essentials3URLVSgtcfc
                 U $s10Foundation5NSURLCMa
bash-4.2# nm Examples/APIGatewayV2/.build/release/APIGatewayLambda | grep -i foundation | grep -v -i essentials
                 U $s10Foundation5NSURLCMa

I don't know if this is the CI test that never worked and start to work and produce these error or if something has changed.

I can't find a recent code change that caused this, neither in the runtime or on the event library. I even tried the event library v1, before your change for Codable)

When testing for libFoundation on the helloworld example, it is negative. I think the link is caused by something in the event library.
But I can't find anything on the event library

bash-4.2# swift build -c release
Building for production...
[7/7] Compiling AWSLambdaEvents ALB.swift
Build complete! (13.20s)
bash-4.2# nm .build/release/AWSLambdaEvents.build/*.o  | grep -i foundation | grep -v -i essentials
bash-4.2# nm .build/release/AWSLambdaEvents.build/*.o  | grep -i nsurl                             
bash-4.2#

@sebsto
Copy link
Collaborator Author

sebsto commented Oct 20, 2025

Root cause is apple/swift-http-types#107

@sebsto sebsto marked this pull request as ready for review October 20, 2025 18:01
@sebsto sebsto merged commit 8168a5c into main Oct 20, 2025
40 checks passed
@sebsto sebsto deleted the sebsto/fix_ci branch October 20, 2025 18:01
sebsto added a commit that referenced this pull request Oct 21, 2025
Revert change on
#593

The root cause has been addressed in the Swift AWS Lambda Event library 
awslabs/swift-aws-lambda-events#99

Co-authored-by: Sebastien Stormacq <stormacq@amazon.lu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔨 semver/patch No public API change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant