Feature/ff local server #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
force-pushed
the
feature/ff-local-server
branch
from
d67c801 to
f0f5e4b
Compare
tomerd
reviewed
May 5, 2020
|
|
||
| private var processing = CircularBuffer<(head: HTTPRequestHead, body: ByteBuffer?)>() | ||
|
|
||
| private static var queue = [Pending]() |
There was a problem hiding this comment.
use CircularBuffer, and then you can pop as optional
tomerd
reviewed
May 5, 2020
| #warning("better error code?!") | ||
| return self.writeResponse(context: context, response: .init(status: .conflict)) | ||
| } | ||
| guard requestId == pending.requestId else { |
There was a problem hiding this comment.
I used a dictionary to make sure we bring the right pending request, this will make it order based in case you have some concurrency between the client submitting work (eg iOS app) and the lambda polling/processing work (lambda code)
tomerd
reviewed
May 5, 2020
| final class HTTPHandler: ChannelInboundHandler { | ||
|
|
||
| enum InvocationState { | ||
| case waitingForNextRequest |
tomerd
reviewed
May 5, 2020
|
|
||
| enum InvocationState { | ||
| case waitingForNextRequest | ||
| case idle(EventLoopPromise<Pending>) |
tomerd
reviewed
May 5, 2020
| enum InvocationState { | ||
| case waitingForNextRequest | ||
| case idle(EventLoopPromise<Pending>) | ||
| case processing(Pending) |
tomerd
reviewed
May 5, 2020
| } | ||
| Self.queueLock.withLock { | ||
| Self.queue[requestId] = Pending(requestId: requestId, request: work, responsePromise: promise) | ||
| let pending = Pending(requestId: requestId, request: work, responsePromise: promise) |
tomerd
reviewed
May 5, 2020
| } | ||
|
|
||
| // pop the first task from the queue | ||
| switch !Self.queue.isEmpty ? Self.queue.removeFirst() : nil { |
There was a problem hiding this comment.
circular buffer will make this easier
|
@fabianfett merged this and will continue to iterate on the original branch |
fabianfett
added a commit
that referenced
this pull request
May 7, 2020
* Don’t exit immediately * Removed locks. Just running in one EL
fabianfett
added a commit
that referenced
this pull request
May 12, 2020
* Don’t exit immediately * Removed locks. Just running in one EL
fabianfett
added a commit
that referenced
this pull request
May 12, 2020
* Don’t exit immediately * Removed locks. Just running in one EL
fabianfett
added a commit
that referenced
this pull request
May 13, 2020
* Don’t exit immediately * Removed locks. Just running in one EL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented some of the comments.