Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #29.
Why
Kill switch / disable is a universal platform behavior. Enforcement belongs at the backend boundary, not per-client. Madtank called this out 2026-04-09: "the fix for some of this landed in CLI repository, but that doesn't make sense because this needs to be a universal pause so this needs to be on the API".
PR #29 added client-side enforcement in `ax listen`. That was the wrong shape. Every client reimplementing the check is another escape hatch, and it teaches exactly the pattern the team is trying to un-learn.
What replaces it
Backend PR ax-backend @ `d6fb390` adds the filter in `messages_notifications.broadcast_sse()`, right after the mentions list is finalized and before any publisher runs. It resolves mention handles to in-space Agent records, batch-fetches their control states via `AgentControlService`, and drops disabled agents from both the `mentions` list and the `explicit_mentions` snapshot. Every downstream publisher — SSE `message` event, SSE `mention` event, MCP bus mention event, dispatch loop, webhook delivery — now sees the pre-filtered list. Enforcement is consistent across transports, in one place, with no per-client duplication.
Test plan