Merged
Conversation
Collaborator
|
@tomas-winkler-sndk : and it generated the following warnings: Any ideas? |
vincentkfu
reviewed
Sep 17, 2025
Collaborator
vincentkfu
left a comment
There was a problem hiding this comment.
Let's just drop this patch? It does not seem related to sprandom. What is liat? There should be an explanation for the changes as well.
Add 5 simple sprandom tests. These currently verify that the feature does not break under normal use and properly handles invalid arguments. Signed-off-by: Tomas Winkler <tomas.winkler@sandisk.com>
91ecaa2 to
b88f884
Compare
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 5 simple sprandom tests. These currently verify that the feature
does not break under normal use and properly handles invalid arguments.