Remove leftover code for platforms lacking clock_gettime and clockid_t#1999
Merged
axboe merged 1 commit intoaxboe:masterfrom Oct 30, 2025
betonmischer86:clock_gettime
Merged
Remove leftover code for platforms lacking clock_gettime and clockid_t#1999axboe merged 1 commit intoaxboe:masterfrom betonmischer86:clock_gettime
axboe merged 1 commit intoaxboe:masterfrom
betonmischer86:clock_gettime
Conversation
sitsofe
reviewed
Oct 9, 2025
Collaborator
sitsofe
left a comment
sitsofe
left a comment
There was a problem hiding this comment.
I'm not sure why we saw a few CI failures so I'm just retriggering those. Other than that this looks good (but I would say that wouldn't I?) and I like the commit message body. The only thing I'd suggest is amending the commit title to something briefer like:
gettime: remove non-clock_gettime fallback code
Platforms that lack clock_gettime are de facto unsupported. Drop the remaining workaround code and produce an error on configure if clock_gettime is unavailable. Also remove the related workaround for platforms lacking clockid_t. Signed-off-by: Valeriy Kosikhin <vkosikhin@gmail.com>
sitsofe
approved these changes
Oct 12, 2025
Collaborator
There was a problem hiding this comment.
@vincentkfu, @axboe this LGTM (and it saves a configure probe).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the remaining workaround code for platforms lacking clock_gettime and clockid_t. Produce an error on configure if clock_gettime is unavailable.
Submitted on behalf of @sitsofe.