Skip to content

[GIT PULL] examples/proxy: Fix for BIDI#1350

Merged
axboe merged 1 commit intoaxboe:masterfrom
SidongYang:fix-proxy-bidi
Feb 18, 2025
Merged

[GIT PULL] examples/proxy: Fix for BIDI#1350
axboe merged 1 commit intoaxboe:masterfrom
SidongYang:fix-proxy-bidi

Conversation

@SidongYang
Copy link
Contributor

When proxy works without multishot, it needs to submit additional receive. Old code uses direction in index 0 without considering BIDI and it triggers assertion for checking cd->pending_recv. This patch fixes to use corresponding direction also fd.

Issue: #1338


git request-pull output:

The following changes since commit 6c509e2b0c881a13b83b259a221bf15fc9b3f681:

  test/sqwait: cleanup allocated iovecs (2025-01-22 19:48:36 -0700)

are available in the Git repository at:

  https://github.com/SidongYAng/liburing fix-proxy-bidi

for you to fetch changes up to 7f0089994c53d42478445c5b17d2223103eec275:

  examples/proxy: Fix for BIDI (2025-02-17 17:05:41 +0000)

----------------------------------------------------------------
Sidong Yang (1):
      examples/proxy: Fix for BIDI

 examples/proxy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Click to show/hide pull request guidelines

Pull Request Guidelines

  1. To make everyone easily filter pull request from the email
    notification, use [GIT PULL] as a prefix in your PR title.
[GIT PULL] Your Pull Request Title
  1. Follow the commit message format rules below.
  2. Follow the Linux kernel coding style (see: https://github.com/torvalds/linux/blob/master/Documentation/process/coding-style.rst).

Commit message format rules:

  1. The first line is title (don't be more than 72 chars if possible).
  2. Then an empty line.
  3. Then a description (may be omitted for truly trivial changes).
  4. Then an empty line again (if it has a description).
  5. Then a Signed-off-by tag with your real name and email. For example:
Signed-off-by: Foo Bar <foo.bar@gmail.com>

The description should be word-wrapped at 72 chars. Some things should
not be word-wrapped. They may be some kind of quoted text - long
compiler error messages, oops reports, Link, etc. (things that have a
certain specific format).

Note that all of this goes in the commit message, not in the pull
request text. The pull request text should introduce what this pull
request does, and each commit message should explain the rationale for
why that particular change was made. The git tree is canonical source
of truth, not github.

Each patch should do one thing, and one thing only. If you find yourself
writing an explanation for why a patch is fixing multiple issues, that's
a good indication that the change should be split into separate patches.

If the commit is a fix for an issue, add a Fixes tag with the issue
URL.

Don't use GitHub anonymous email like this as the commit author:

123456789+username@users.noreply.github.com

Use a real email address!

Commit message example:

src/queue: don't flush SQ ring for new wait interface

If we have IORING_FEAT_EXT_ARG, then timeouts are done through the
syscall instead of by posting an internal timeout. This was done
to be both more efficient, but also to enable multi-threaded use
the wait side. If we touch the SQ state by flushing it, that isn't
safe without synchronization.

Fixes: https://github.com/axboe/liburing/issues/402
Signed-off-by: Jens Axboe <axboe@kernel.dk>

By submitting this pull request, I acknowledge that:

  1. I have followed the above pull request guidelines.
  2. I have the rights to submit this work under the same license.
  3. I agree to a Developer Certificate of Origin (see https://developercertificate.org for more information).

When proxy works without multishot, it needs to submit additional
receive. Old code uses direction in index 0 without considering
BIDI and it triggers assertion for checking cd->pending_recv.
This patch fixes to use corresponding direction also fd.

Issue: axboe#1338

Signed-off-by: Sidong Yang <sidong.yang@furiosa.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants