Skip to content

Conversation

@Meiye-lj
Copy link
Contributor

@Meiye-lj Meiye-lj commented Sep 6, 2025

Fixing missing dependencies in src/Makefile

This PR fixes an issue in the Makefile. Specifically, previously, any modifications of files like src/include/liburing/io_uring.h would not trigger a rebuild of ffi.os. The PR fixes this by including them as additional dependencies.

Signed-off-by: Jun Lyu lvjun_dnt@outlook.com

Copy link
Contributor

@ammarfaizi2 ammarfaizi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing missing dependencies in src/Makefile

This PR fixes an issue in the Makefile. Specifically, previously, any modifications of files like src/include/liburing/io_uring.h would not trigger a rebuild of ffi.os. The PR fixes this by including them as additional dependencies.

Signed-off-by: Jun Lyur lvjun_dnt@outlook.com

The explanation and the Signed-off-by tag should go into the commit message. Your pull request msg won't be included in the git tree anyway.

@Meiye-lj
Copy link
Contributor Author

Meiye-lj commented Sep 6, 2025

Fixing missing dependencies in src/Makefile
This PR fixes an issue in the Makefile. Specifically, previously, any modifications of files like src/include/liburing/io_uring.h would not trigger a rebuild of ffi.os. The PR fixes this by including them as additional dependencies.
Signed-off-by: Jun Lyur lvjun_dnt@outlook.com

The explanation and the Signed-off-by tag should go into the commit message. Your pull request msg won't be included in the git tree anyway.

updated the msg

Copy link
Contributor

@ammarfaizi2 ammarfaizi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the msg

One more missing bit, please word wrap the commit message at 72 chars. Also, the format of the Signed-off-by tag is:

Signed-off-by: Your Name <your_email@example.com>

See 01f89b6 for the example.

This PR fixes an issue in the Makefile. Specifically, previously, any
modifications of files like src/include/liburing/io_uring.h would not
trigger a rebuild of ffi.os. The PR fixes this by including them as
additional dependencies.

Signed-off-by: Jun Lyu <lvjun_dnt@outlook.com>
@Meiye-lj
Copy link
Contributor Author

Meiye-lj commented Sep 6, 2025

updated the msg

One more missing bit, please word wrap the commit message at 72 chars. Also, the format of the Signed-off-by tag is:

Signed-off-by: Your Name <your_email@example.com>

See 01f89b6 for the example.

Thanks and updated

@axboe axboe merged commit 005d529 into axboe:master Sep 6, 2025
18 checks passed
@axboe
Copy link
Owner

axboe commented Sep 6, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants