Merged
Conversation
Owner
|
Can you rebase on master? There seems to be a few bottom commits that I don't know where that sha is from, the ones talking about test/io-wq-exit? |
Collaborator
Author
|
Weird, that's definitely a test that was pulled from the main repo, maybe some intermediate rebase screwed the hash though. I'll rebase |
Owner
|
Yeah odd, neither of the two shas: axboe@m2max ~/gi/liburing (master)> git show f56c512 exist in my main repo. Maybe a cherry-pick or a rebase that went badly? Doesn't matter, just need a rebase + drop and it can get pulled. |
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
In preparation for removing payload size limits, always allocate the payload buffer dynamically and unify it with huge pages. Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
The 65K payload restriction is needed only for UDP, and it doesn't allow to squeeze all performance out of TCP, lift the limit. Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
1024 CQ entries is inadequate for high throughput setups, increase the size. It can be turned into a parameter later. Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Currently sockets get a silent treatment and that's very inconvenient for testing, print some info about the socket on accept. Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Pass actual error codes to t_error. Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
The head is published with a release semantics and can happen on any CPU, the user space must use acquire / read barriers. Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
The program prints invalid result even when the client successfully terminates it. Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
32 MB is not enough to initially even populate rings of some cards, set the default area size to 256 MB. And don't measure it in pages, we care about the total amount of memory. Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
The request can get terminated if the CQ becomes full, handle it by reissuing the request. Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Owner
|
To be clear, the test does exist in my branch, just not those shas. |
55b2be9 to
df9cbfe
Compare
Collaborator
Author
|
Should be fine now |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update zerocopy tx/rx benchmarks. It fixes a couple of issues with the initial zcrx example code, and add a bunch of features.