Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request dramatically improves the startup performance of paired tmux sessions. By integrating the initial Codex prompt directly into the launch command and removing several polling and fixed delay mechanisms, the time taken for a fresh session to become ready has been reduced from approximately 9.3 seconds to 1.4 seconds. This optimization enhances the responsiveness and efficiency of the development environment. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the prompt handling and session startup logic for Claude and Codex agents within the tmux module. Key changes include reducing CLAUDE_PROMPT_INITIAL_POLLS from 8 to 4, removing several constants and functions related to Codex readiness polling and prompt seeding, and modifying buildCodexCommand to directly accept the codexPrompt. The startPairedSession function has been simplified by removing explicit prompt dispatching logic. Corresponding tests have been updated to reflect these changes, including removing assertions about typed prompts and adding new tests for Claude startup wait times and delayed trust prompt handling. No feedback to provide.
Summary
Verification
Notes