Skip to content

Clarify interactive tmux plan-review flow#43

Merged
axeldelafosse merged 1 commit intomainfrom
codex/interactive-tmux-plan-review
Mar 27, 2026
Merged

Clarify interactive tmux plan-review flow#43
axeldelafosse merged 1 commit intomainfrom
codex/interactive-tmux-plan-review

Conversation

@axeldelafosse
Copy link
Copy Markdown
Owner

Summary

  • tell the interactive tmux primary prompt to write PLAN.md, ask the peer for plan review, iterate on the plan, then ask the human to review it before implementing
  • tell the interactive tmux peer prompt how to handle a plan-review request
  • extend tmux prompt tests to cover both instructions

Verification

  • bun test tests/loop/tmux.test.ts
  • bun run check

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a 'plan mode' workflow to the tmux interactive prompts, instructing agents to create, review, and iterate on a PLAN.md file before implementation. The feedback suggests improving the robustness of the associated tests by asserting the full content of the new prompt instructions rather than using fragmented checks.

Comment on lines +799 to +801
expect(primaryPrompt).toContain("If the human asks for plan mode");
expect(primaryPrompt).toContain("ask Claude for a plan review");
expect(primaryPrompt).toContain("ask the human to review the plan");
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These checks for the primary agent's prompt are a bit fragmented and miss some key parts of the new instruction, such as write PLAN.md first and iterate on PLAN.md. Combining them into a single, more comprehensive assertion will make the test more robust and ensure the entire instruction is present.

Suggested change
expect(primaryPrompt).toContain("If the human asks for plan mode");
expect(primaryPrompt).toContain("ask Claude for a plan review");
expect(primaryPrompt).toContain("ask the human to review the plan");
expect(primaryPrompt).toContain(
"If the human asks for plan mode, write PLAN.md first, ask Claude for a plan review, iterate on PLAN.md, then ask the human to review the plan before implementing"
);

Comment on lines +807 to +809
expect(peerPrompt).toContain(
"If Codex asks for a plan review, review PLAN.md only"
);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This check for the peer agent's prompt is incomplete. It misses important parts of the instruction like suggest concrete fixes and wait for the next request. A more comprehensive assertion would improve the test's coverage and robustness.

Suggested change
expect(peerPrompt).toContain(
"If Codex asks for a plan review, review PLAN.md only"
);
expect(peerPrompt).toContain(
"If Codex asks for a plan review, review PLAN.md only, suggest concrete fixes, and wait for the next request"
);

@axeldelafosse axeldelafosse marked this pull request as ready for review March 27, 2026 05:34
@axeldelafosse axeldelafosse merged commit c30f245 into main Mar 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant