Clarify interactive tmux plan-review flow#43
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a 'plan mode' workflow to the tmux interactive prompts, instructing agents to create, review, and iterate on a PLAN.md file before implementation. The feedback suggests improving the robustness of the associated tests by asserting the full content of the new prompt instructions rather than using fragmented checks.
| expect(primaryPrompt).toContain("If the human asks for plan mode"); | ||
| expect(primaryPrompt).toContain("ask Claude for a plan review"); | ||
| expect(primaryPrompt).toContain("ask the human to review the plan"); |
There was a problem hiding this comment.
These checks for the primary agent's prompt are a bit fragmented and miss some key parts of the new instruction, such as write PLAN.md first and iterate on PLAN.md. Combining them into a single, more comprehensive assertion will make the test more robust and ensure the entire instruction is present.
| expect(primaryPrompt).toContain("If the human asks for plan mode"); | |
| expect(primaryPrompt).toContain("ask Claude for a plan review"); | |
| expect(primaryPrompt).toContain("ask the human to review the plan"); | |
| expect(primaryPrompt).toContain( | |
| "If the human asks for plan mode, write PLAN.md first, ask Claude for a plan review, iterate on PLAN.md, then ask the human to review the plan before implementing" | |
| ); |
| expect(peerPrompt).toContain( | ||
| "If Codex asks for a plan review, review PLAN.md only" | ||
| ); |
There was a problem hiding this comment.
This check for the peer agent's prompt is incomplete. It misses important parts of the instruction like suggest concrete fixes and wait for the next request. A more comprehensive assertion would improve the test's coverage and robustness.
| expect(peerPrompt).toContain( | |
| "If Codex asks for a plan review, review PLAN.md only" | |
| ); | |
| expect(peerPrompt).toContain( | |
| "If Codex asks for a plan review, review PLAN.md only, suggest concrete fixes, and wait for the next request" | |
| ); |
Summary
Verification