Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignored custom config #2006

Closed
wants to merge 4 commits into from
Closed

Conversation

oleduc
Copy link

@oleduc oleduc commented Feb 20, 2019

As described in issue #1718 as of beta-0.19 custom configuration is broken which breaks a plugin that we are using (3846masa/axios-cookiejar-support). This pull request aims to restore the behavior that was present in 0.18.0 without adding a new feature (unlike #1831)

@oleduc
Copy link
Author

oleduc commented Apr 23, 2019

@emilyemorehouse I would greatly appreciate if someone could have a look at this :)

@rafaelrenanpacheco
Copy link
Contributor

rafaelrenanpacheco commented Jun 6, 2019

@emilyemorehouse hello! What's the status on this PR? Look's like there are some conflicts and the author didn't fix it so far. Will you work on this conflicts or would you like a fresh new PR regarding this fix? Lot's of axios plugins are crashing in 0.19 because the custom config was removed.

@jasonsaayman
Copy link
Member

jasonsaayman commented Jun 7, 2019

@oleduc please, can you remove the dist folder from the pull request?

@jasonsaayman
Copy link
Member

jasonsaayman commented Jun 7, 2019

@rafaelrenanpacheco if you want to rather put in a pull request that does not include the dist folder, please do so, then at me in that pull request. I can then close this one and reference to that one.

@rafaelrenanpacheco
Copy link
Contributor

rafaelrenanpacheco commented Jun 7, 2019

Hey @jasonsaayman! Here is the new PR: #2207

Thanks!

@marosivanco
Copy link

marosivanco commented Aug 14, 2019

What are the plans for merging and releasing of this PR? In which version will it be released?

@rafaelrenanpacheco
Copy link
Contributor

rafaelrenanpacheco commented Sep 7, 2019

This fix was merged at #2207

@felipewmartins I think this PR can be closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants