Skip to content

:splarkles: Theme toggler#136

Merged
axllent merged 1 commit intoaxllent:developfrom
jrmessias:dark-mode
Jun 30, 2023
Merged

:splarkles: Theme toggler#136
axllent merged 1 commit intoaxllent:developfrom
jrmessias:dark-mode

Conversation

@jrmessias
Copy link
Copy Markdown
Contributor

Add toggler to change theme (light, dark, auto)

Add toggler to change theme (light, dark, auto)
Copy link
Copy Markdown

@hizotech hizotech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@axllent
Copy link
Copy Markdown
Owner

axllent commented Jun 30, 2023

This is very nice, thank you! I have a bit of testing to do, and some minor styling changes to fix a few issues with the toggle, but I'll definitely be merging this in.

@axllent axllent merged commit 4cfde7f into axllent:develop Jun 30, 2023
@axllent
Copy link
Copy Markdown
Owner

axllent commented Jun 30, 2023

Thanks again for your PR @jrmessias!. I have reworked what you created into a Vue component and shifted the toggle to the bottom left (next to the About link) so it does not interfere with the message display. I am aware that the toggle is not visible nor accessible in mobile view (still on my TODO list), but that seemed a more appropriate position to have it. This has just been released in v1.7.0.

@jrmessias
Copy link
Copy Markdown
Contributor Author

Hi @axllent
Thanks for accept my PR, I understand your considerations, thanks for the code review, I always learning. I always programming at night so dark mode is my default :D
Thank you so much.
Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants