Skip to content

Removed unused AX_SPRITEBATCHNODE_DEBUG_DRAW and AX_LABELATLAS_DEBUG_DRAW #3079

Merged
halx99 merged 3 commits intoaxmolengine:devfrom
aismann:aismann_issue_3078
Mar 6, 2026
Merged

Removed unused AX_SPRITEBATCHNODE_DEBUG_DRAW and AX_LABELATLAS_DEBUG_DRAW #3079
halx99 merged 3 commits intoaxmolengine:devfrom
aismann:aismann_issue_3078

Conversation

@aismann
Copy link
Contributor

@aismann aismann commented Mar 2, 2026

Describe your changes

Add a not implemented comment

Issue ticket number and link

#3078

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

Axmol 3.x ------------------------------------------------------------

For each 3.x PR

  • Check the '#include "axmol.h"' and replace it with the needed headers.

@halx99 halx99 added this to the 3.0.0 milestone Mar 4, 2026
@aismann
Copy link
Contributor Author

aismann commented Mar 5, 2026

a hint on the wiki is enough.
closed it.

@halx99
Copy link
Collaborator

halx99 commented Mar 5, 2026

ok

@halx99 halx99 removed this from the 3.0.0 milestone Mar 5, 2026
@aismann
Copy link
Contributor Author

aismann commented Mar 5, 2026

I've thought about it again. We should add this PR.
As always, the best place for information is where the information is needed.
Sorry for the confusion.

@aismann aismann reopened this Mar 5, 2026
@aismann aismann added this to the 3.0.0 milestone Mar 5, 2026
@halx99
Copy link
Collaborator

halx99 commented Mar 6, 2026

could we just remove these macros since it's not used anywhere?

@rh101
Copy link
Contributor

rh101 commented Mar 6, 2026

could we just remove these macros since it's not used anywhere?

It may be best to remove them, since they serve no purpose, and may just confuse anyone modifying them and not seeing any difference in the output.

@aismann aismann changed the title Some AX_..._DEBUG_DRAW definded but not implemented Removed unsupported AX_SPRITEBATCHNODE_DEBUG_DRAW and AX_LABELATLAS_DEBUG_DRAW Mar 6, 2026
@aismann
Copy link
Contributor Author

aismann commented Mar 6, 2026

Removed, ready for review

@halx99 halx99 added the enhancement New feature or request label Mar 6, 2026
@halx99 halx99 changed the title Removed unsupported AX_SPRITEBATCHNODE_DEBUG_DRAW and AX_LABELATLAS_DEBUG_DRAW Removed unused AX_SPRITEBATCHNODE_DEBUG_DRAW and AX_LABELATLAS_DEBUG_DRAW Mar 6, 2026
@halx99 halx99 merged commit dd7a936 into axmolengine:dev Mar 6, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AX_SPRITEBATCHNODE_DEBUG_DRAW and AX_LABELATLAS_DEBUG_DRAW definded but not implemented

3 participants