Removed unused AX_SPRITEBATCHNODE_DEBUG_DRAW and AX_LABELATLAS_DEBUG_DRAW #3079
Merged
halx99 merged 3 commits intoaxmolengine:devfrom Mar 6, 2026
Merged
Removed unused AX_SPRITEBATCHNODE_DEBUG_DRAW and AX_LABELATLAS_DEBUG_DRAW #3079halx99 merged 3 commits intoaxmolengine:devfrom
halx99 merged 3 commits intoaxmolengine:devfrom
Conversation
…G_DRAW definded but not implemented
Contributor
Author
|
a hint on the wiki is enough. |
Collaborator
|
ok |
Contributor
Author
|
I've thought about it again. We should add this PR. |
Collaborator
|
could we just remove these macros since it's not used anywhere? |
Contributor
It may be best to remove them, since they serve no purpose, and may just confuse anyone modifying them and not seeing any difference in the output. |
Contributor
Author
|
Removed, ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add a
not implementedcommentIssue ticket number and link
#3078
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."I have performed a self-review of my code.
Optional:
For core/new feature PR
Axmol 3.x ------------------------------------------------------------
For each 3.x PR