🤯 Delete implementation #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccamel
force-pushed
the
feat/delete-implementation
branch
from
e25942e to
a85a1b2
Compare
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## main #304 +/- ##
==========================================
+ Coverage 98.04% 98.25% +0.20%
==========================================
Files 41 42 +1
Lines 8861 9696 +835
==========================================
+ Hits 8688 9527 +839
+ Misses 173 169 -4
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ccamel
force-pushed
the
feat/delete-implementation
branch
from
51feace to
31ec289
Compare
|
Status: implementation done. Missing tests. |
ccamel
force-pushed
the
feat/delete-implementation
branch
4 times, most recently
from
6ae0136 to
9561d9d
Compare
…e clause Previously, delete triples was mandatory and the where clause optional. It was incorrect with regards to the W3C specification of the SPARQL DELETE query.
ccamel
force-pushed
the
feat/delete-implementation
branch
from
7ee2610 to
4d5ee31
Compare
amimart
suggested changes
Sep 5, 2023
Co-authored-by: Arnaud Mimart <33665250+amimart@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings addresses #307 by implementing the (missing) DeleteData message in the Cognitarium smart contract, which provides the functionality to delete triples from the contract's state.
DELETEmessage so that the delete triple patterns are now optional but the where clause is compulsory. This change aligns with the W3C's SPARQL DELETE query specification, which serves as our reference point.