Skip to content

Conversation

@ccamel
Copy link
Member

@ccamel ccamel commented Aug 18, 2023

Specifies the CONSTRUCT query over the triple store in the cognitarium smart contract as required by #327.

Notes:

  • The specification draws significant inspiration from the sparql #construct specification.
  • The implementation should be undertaken following 🤯 Delete implementation #304, as it introduces mechanisms that closely align with what is required for this task (at first sight).

@ccamel ccamel self-assigned this Aug 18, 2023
@ccamel ccamel changed the title 🤯 Construct query specification 🤯 CONSTRUCT query specification Aug 18, 2023
@bot-anik
Copy link
Member

bot-anik commented Aug 18, 2023

size-limit report 📦

Path Size
target/wasm32-unknown-unknown/release/okp4_objectarium.wasm 427.74 KB (0%)
target/wasm32-unknown-unknown/release/okp4_law_stone.wasm 636.59 KB (0%)
target/wasm32-unknown-unknown/release/okp4_cognitarium.wasm 766.04 KB (+1.23% 🔺)

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #318 (5c653d0) into main (254654f) will decrease coverage by 0.01%.
The diff coverage is 97.36%.

@@            Coverage Diff             @@
##             main     #318      +/-   ##
==========================================
- Coverage   98.05%   98.04%   -0.01%     
==========================================
  Files          41       41              
  Lines        8786     8861      +75     
==========================================
+ Hits         8615     8688      +73     
- Misses        171      173       +2     
Files Changed Coverage Δ
contracts/okp4-cognitarium/src/msg.rs 85.26% <33.33%> (-1.70%) ⬇️
contracts/okp4-cognitarium/src/contract.rs 99.37% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ccamel ccamel force-pushed the feat/cognitarium-construct-api-specification branch from e3f38c7 to eed8158 Compare August 18, 2023 17:44
@ccamel ccamel marked this pull request as ready for review August 18, 2023 18:28
@ccamel ccamel force-pushed the feat/cognitarium-construct-api-specification branch from eed8158 to 5c653d0 Compare August 23, 2023 08:05
Copy link
Contributor

@bdeneux bdeneux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ccamel ccamel merged commit 3a81fed into main Aug 25, 2023
@ccamel ccamel deleted the feat/cognitarium-construct-api-specification branch August 25, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants