Skip to content

Fix(oauth2): enforce owner-scoped PAT deletion #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Musicminion wants to merge 1 commit into
base: server-pro
Choose a base branch
from
Open

Fix(oauth2): enforce owner-scoped PAT deletion #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion services/web/modules/oauth2-server/app/src/OAuthPersonalAccessTokenController.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,10 @@ const PersonalAccessTokenController = {
return res.status(400).json({ message: 'Token id is required' })
}

await OAuthPersonalAccessTokenManager.removeToken(tokenId)
const result = await OAuthPersonalAccessTokenManager.removeToken(tokenId, user._id)
if (!result || result.deletedCount !== 1) {
return res.status(404).json({ message: 'Token not found' })
}

return res.json({
message: 'Token deleted',
Expand Down
9 changes: 7 additions & 2 deletions services/web/modules/oauth2-server/app/src/OAuthPersonalAccessTokenManager.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,15 @@ const PersonalAccessTokenManager = {
return accessToken
},

// Delete a personal access token
async removeToken(tokenId) {
// Delete a personal access token owned by a specific user
async removeToken(tokenId, userId) {
if (!ObjectId.isValid(tokenId)) {
return { deletedCount: 0 }
}
const query = {
_id: new ObjectId(tokenId),
user_id: userId,
type: 'personal_access_token',
}

// Delete token from database
Expand Down
Loading