Skip to content

Revert "feat(dropbar): replace path with custom source"#1435

Closed
ayamir wants to merge 1 commit intomainfrom
revert-1430-feat/dropbar-path-src-custom
Closed

Revert "feat(dropbar): replace path with custom source"#1435
ayamir wants to merge 1 commit intomainfrom
revert-1430-feat/dropbar-path-src-custom

Conversation

@ayamir
Copy link
Owner

@ayamir ayamir commented Mar 17, 2025

This patch revert #1430. This will cause inconvenience when open library file, make it hard to distinguish it with repo files.

@ayamir ayamir requested a review from Jint-lzxy March 17, 2025 10:01
@Jint-lzxy
Copy link
Collaborator

My bad for the slow reply! Honestly I feel like this should be how it works lol I switched the path source to be relative to cwd cuz bufferline alr shows the full path if there's duplicate file names + we also have the cwd in the bottom right (kinda same as how it was before dropbar came in too). Not sure what the issue is here tbh but lmk if I'm missing something!

@ayamir
Copy link
Owner Author

ayamir commented Mar 28, 2025

we also have the cwd in the bottom right

It's fine, maybe I should change my habbit.

@ayamir ayamir closed this Mar 28, 2025
@Jint-lzxy
Copy link
Collaborator

It's fine, maybe I should change my habbit.

lol no worries we can def discuss diff options here! my main motivation behind this is just making things more consistent w the other changes we've made but like always we can tweak our own config however we want 🤣 a better way to do this is prob to integrate w project.nvim and use the default path source with the root set to whatever project.nvim reports, but we'd have to turn off manual_mode for project.nvim tho... that way all the files share a common root but still stay separate based on the project, and anything outside will just show the full path

@ayamir ayamir deleted the revert-1430-feat/dropbar-path-src-custom branch April 20, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments