Conversation
There was a problem hiding this comment.
Pull request overview
Adds a user-facing “Max Frame Rate” setting under Preferences → Cat Settings → Model Settings to limit Live2D rendering FPS (issue #933), wiring the persisted store value to Pixi’s ticker.
Changes:
- Add
maxFPSto the cat model store with a default value. - Add a preference UI control to edit
maxFPS. - Apply
maxFPSat runtime by watching the store and updatingTicker.shared.maxFPS. - Add i18n strings for the new setting across all supported locales.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/live2d.ts | Adds setMaxFPS() to apply the FPS limit to Pixi’s shared ticker. |
| src/stores/cat.ts | Persists new model.maxFPS setting with a default. |
| src/pages/preference/components/cat/index.vue | Adds an InputNumber control for configuring max FPS in Preferences. |
| src/pages/main/index.vue | Watches model.maxFPS and applies it immediately via live2d.setMaxFPS. |
| src/locales/zh-TW.json | Adds label/hint translations for maxFPS. |
| src/locales/zh-CN.json | Adds label/hint translations for maxFPS. |
| src/locales/vi-VN.json | Adds label/hint translations for maxFPS. |
| src/locales/pt-BR.json | Adds label/hint translations for maxFPS. |
| src/locales/en-US.json | Adds label/hint translations for maxFPS. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolved #933