Fix duplicate extern declaration in cnee_demo.c and document Makefile.gdoc no-op intent#7
Merged
Merged
Conversation
Merged
Co-authored-by: ayanimea <13433370+ayanimea@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add GitHub Actions workflows for EL 6 and 8
Fix duplicate extern declaration in cnee_demo.c and document Makefile.gdoc no-op intent
Mar 8, 2026
There was a problem hiding this comment.
Pull request overview
This PR addresses two minor code-quality issues: removing a duplicate extern declaration in cnee/src/cnee_demo.c and adding documentation comments to the no-op doc/Makefile.gdoc.
Changes:
- Replaced a local
extern xnee_option_t *cnee_options;redeclaration incnee_demo.cwith#include "cnee.h", which canonically declares the same symbol. - Added comments to
doc/Makefile.gdocexplaining it is an intentional no-op placeholder.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
cnee/src/cnee_demo.c |
Removed duplicate extern declaration; added #include "cnee.h" to import the canonical declaration from the header. |
doc/Makefile.gdoc |
Added comments explaining the file's purpose as a no-op placeholder for gdoc build variables. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two issues flagged in review: a duplicate
externdeclaration drifting out of sync with its canonical header, and a tracked build file with no explanation of its purpose.Changes
cnee/src/cnee_demo.c— Removed localextern xnee_option_t *cnee_options;redeclaration; replaced with#include "cnee.h"which already declares it. Eliminates the risk of the two declarations diverging.doc/Makefile.gdoc— Added comments clarifying the file is an intentional no-op placeholder. The file is also generated bycfg.mk'sautoreconftarget; keeping it tracked with context prevents future confusion.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.