Fix version assertion case sensitivity and Makefile.am texinfo filename inconsistency#8
Merged
Merged
Conversation
Merged
…nconsistency Co-authored-by: ayanimea <13433370+ayanimea@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add automation for building on Enterprise Linux 6 and 8
Fix version assertion case sensitivity and Makefile.am texinfo filename inconsistency
Mar 8, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes two independent bugs: a case-sensitivity mismatch in the e2e test suite's version assertions, and an inconsistent generated filename in the cnee/src/Makefile.am man target.
Changes:
- Updated two
assert_output_containsversion assertions intests/e2e_cnee.shto use the alternation patternXnee\|xnee, matching the actual output ofxnee_version()which printsPACKAGE(expanded asXnee). - Corrected the
mantarget incnee/src/Makefile.amto outputcnee.texiinstead ofcnee.texinfo, aligning it withBUILT_SOURCES,CLEAN_FILES,texi_TEXINFOS, and the standalonecnee.texirule.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/e2e_cnee.sh |
Fixes two version-check assertions to use case-insensitive alternation Xnee|xnee, preventing false failures when PACKAGE is Xnee. |
cnee/src/Makefile.am |
Fixes the man target to write cnee.texi instead of cnee.texinfo, eliminating the stale file left behind by make clean. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs in the e2e test suite and build system identified in review.
tests/e2e_cnee.sh— version assertion case mismatchxnee_version()printsXnee(capital X viaPACKAGE), but assertions were matching lowercasexnee, causing false failures on case-sensitive grep. Updated toXnee\|xneealternation (the helper already converts\|to ERE|):cnee/src/Makefile.am— inconsistent generated filename inmantargetThe
mantarget was generatingcnee.texinfo, whileBUILT_SOURCES,texi_TEXINFOS,CLEAN_FILES, and the standalonecnee.texirule all usecnee.texi. This leftcnee.texinfouncleaned bymake clean. Standardized themantarget to outputcnee.texiso it's covered by the existingCLEAN_FILESentry.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.