Skip to content

Fix frame orders on flamegraphs (trace_log.symbols was not reversed) and support versions w/o trace_log.symbols #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azat merged 2 commits into from
Aug 9, 2025
Merged

Fix frame orders on flamegraphs (trace_log.symbols was not reversed) and support versions w/o trace_log.symbols #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32f83f2
Fix frame orders on flamegraphs (trace_log.symbols was not reversed)
azat Aug 9, 2025
4d0ee8b
Support clickhouse version w/o system.trace_log.symbols (<=24.12)
azat Aug 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions src/interpreter/clickhouse.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,13 +836,7 @@ impl ClickHouse {
{} AS start_time_,
{} AS end_time_
SELECT
if(empty(symbols),
arrayStringConcat(arrayMap(
addr -> demangle(addressToSymbol(addr)),
arrayReverse(trace)
), ';'),
arrayStringConcat(symbols, ';')
) AS human_trace,
{} AS human_trace,
{} weight
FROM {}
WHERE
Expand All @@ -869,6 +863,24 @@ impl ClickHouse {
),
None => "toDateTime64(now(), 6)".to_string(),
},
if self.quirks.has(ClickHouseAvailableQuirks::TraceLogHasSymbols) {
r#"
if(empty(symbols),
arrayStringConcat(arrayMap(
addr -> demangle(addressToSymbol(addr)),
arrayReverse(trace)
), ';'),
arrayStringConcat(arrayReverse(symbols), ';')
)
"#
} else {
r#"
arrayStringConcat(arrayMap(
addr -> demangle(addressToSymbol(addr)),
arrayReverse(trace)
), ';')
"#
},
match trace_type {
TraceType::Memory => "abs(sum(size))",
_ => "count()",
Expand Down
5 changes: 4 additions & 1 deletion src/interpreter/clickhouse_quirks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,11 @@ pub enum ClickHouseAvailableQuirks {
ProcessesElapsed,
ProcessesCurrentDatabase,
AsynchronousMetricsTotalIndexGranularityBytesInMemoryAllocated,
TraceLogHasSymbols,
}

const QUIRKS: [(&str, ClickHouseAvailableQuirks); 3] = [
// List of quirks (that requires workaround) or new features.
const QUIRKS: [(&str, ClickHouseAvailableQuirks); 4] = [
// https://github.com/ClickHouse/ClickHouse/pull/46047
//
// NOTE: I use here 22.13 because I have such version in production, which is more or less the
Expand All @@ -23,6 +25,7 @@ const QUIRKS: [(&str, ClickHouseAvailableQuirks); 3] = [
">=24.11, <25.6",
ClickHouseAvailableQuirks::AsynchronousMetricsTotalIndexGranularityBytesInMemoryAllocated,
),
(">=25.1", ClickHouseAvailableQuirks::TraceLogHasSymbols),
];

pub struct ClickHouseQuirks {
Expand Down
Loading