Significantly optimize logs rendering (CPU and Memory)#197
Merged
Conversation
There is no need to build complete content for all logs, it can be constructed only for visible part of log, the only thing that we need is to calculate the total number of rows (with respecting wrapping), for this we can store array of sums. This should make rendering faster: - incremental logs processing faster (since it does construct the StyledString on new data) - filters And also reduces memory consumption 2x - confirmed in manual tests (300MiB -> 150MiB)
azat
added a commit
that referenced
this pull request
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need to build complete content for all logs, it can be
constructed only for visible part of log, the only thing that we need is
to calculate the total number of rows (with respecting wrapping),
for this we can store array of sums.
This should make rendering faster:
And also reduces memory consumption 2x - confirmed in manual tests
(300MiB -> 150MiB)