Merged
Conversation
Perfetto renders byte counters with human-readable units (e.g. "1.5 MB") instead of raw numbers. Applies to both trace_log and query_metric_log ProfileEvent counters, including per-server tracks. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Scale Microseconds (×1000), Milliseconds (×1000000), and Nanoseconds (×1) to nanoseconds so Perfetto renders them as human-readable durations. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Use chars().take(80) instead of byte slice &message[..80] which panics if byte 80 falls in the middle of a multi-byte character. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove truncation — use the complete message as the slice name. The message was already duplicated in annotations, so drop that too. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ORDER BY event_time_microseconds for chronological consistency with all other Perfetto queries (was query_id, thread_id). Remove unused thread_id from SELECT. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
All other Perfetto methods include query_id in annotations for traceability; text_logs was the only one missing it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.