Merged
Conversation
Shows all current chdig options grouped by section (ClickHouse, View, Service, Perfetto, Runtime) in a dialog overlay, following the same pattern as the help dialog. Fixes: #188 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace Option<bool> fields in ChDigPerfettoConfig with bool and a manual Default impl that provides the actual defaults (previously scattered as unwrap_or calls in worker.rs). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace read-only text display with Checkbox widgets for boolean options and EditView for numeric fields (limit, delay_interval). Apply button writes values back to context and triggers a view refresh. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
azat
changed the title
Show resolved DateTime values in editable fields, parsed back via parse_datetime_or_date on apply (same format as Alt+T dialog). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Parse via RelativeDateTime::from_str instead of parse_datetime_or_date so both relative durations and absolute datetimes work. Add to_editable_string() to display the original format round-trippably. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #188