refactor(dlp): split pii.rs into cards/iban/bic (T-SP-4 #10)#243
Merged
Destynova2 merged 3 commits intomainfrom Apr 21, 2026
Merged
refactor(dlp): split pii.rs into cards/iban/bic (T-SP-4 #10)#243Destynova2 merged 3 commits intomainfrom
Destynova2 merged 3 commits intomainfrom
Conversation
added 3 commits
April 21, 2026 22:10
Move credit card regex, Luhn validation, and CC canary generation into src/features/dlp/cards.rs. pii.rs re-exports luhn_check for backward compat with external doctests. First of three splits to slim pii.rs from 1250 LoC toward orchestration- only (audit item #10 Tier 2).
Move IBAN regex, ISO 7064 mod-97 validation, and IBAN canary generator into src/features/dlp/iban.rs. pii.rs re-exports iban_mod97_check for backward compat with external doctests. Second of three splits to slim pii.rs toward orchestration-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split monolithic
src/features/dlp/pii.rsby PII type per audit item #10 Tier 2.CreditCardregex, Luhn check, canary generator →cards.rsIbanregex, ISO 7064 mod-97 check, canary generator →iban.rsBicregex, ISO 9362 format check, country codes table, canary generator →bic.rspii.rskeeps thePiiTypeenum,PiiScannerorchestrator, canary dispatch, and integration testsNotes
Initial audit suggested extracting emails and names, but those already live in separate modules (
dlp::names). Actual decomposable content was the three validators above.All mutation-testing-targeted tests (`test_kill_mutant_*`) are preserved — structural tests moved with their subject, dispatch tests stay in
pii.rs.LOC before:
pii.rs1143. After:pii.rs627,cards.rs256,iban.rs193,bic.rs187.Test plan