chore(deploy): Type=exec on grob.container + close Tier 2 CI cluster (#15 #16 #17 #18 #19 #20)#256
Merged
Destynova2 merged 1 commit intomainfrom Apr 22, 2026
Merged
Conversation
Type=simple treats the service as started the instant fork() returns, so an immediate execve() failure (missing image, bad arg) surfaces as a restart loop rather than a clean start failure. Type=exec waits for execve() to succeed before considering the unit started. Type=notify was suggested by the audit but is wrong for grob: the binary does not call sd_notify, so systemd would block on a readiness signal that never arrives. Readiness stays with the Quadlet HealthCmd. Closes Tier 2 item #20. Items #15-#19 were already landed in #225 (ci/phoenix-tier2-pipeline). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tier 2 CI/infra audit cluster close-out.
Only #20 needed a code change — items #15 through #19 had already landed in #225 (ci/phoenix-tier2-pipeline) before this branch was cut. This PR is scoped to the last remaining item plus a status note so the tracker can close.
#20 — deploy/grob.container Type=simple → Type=exec
Type=simpleconsiders the unit started the instantfork()returns, so an immediateexecve()failure (missing image, bad arg) presents as a restart loop rather than a clean start failure.Type=execwaits forexecve()to succeed, surfacing exec-time failures as real unit failures and lettingRestart=on-failuredo the right thing.The audit suggested
Type=notify, but that is wrong for grob: the binary does not callsd_notify, so systemd would block forever on a readiness signal that never arrives. Readiness stays with the QuadletHealthCmd. Rationale is inlined in the unit file as a# NOTE:so future readers do not retrynotify.Already-landed items (status only, no change in this PR)
ci.ymlretry-masking on hurl/k6# NOTE: no retry — flaky E2E must be fixed at the sourceci-docs-shim.ymlorphan.github/workflows/rustsec/audit-checkcronaudit-cron.ymlwithcron: '17 4 * * *'release-plz.ymltimeoutsrelease-prandrelease-tagjobs already carrytimeout-minutes: 10nightly.ymlmulti-OS + alertalertjob opens/updates a tracking issue on beta failureTest plan
systemd-analyze verify deploy/grob.containerpasses🤖 Generated with Claude Code