fix(ci,openai): unbreak Docs Lint + bump rustls-webpki sec patch#261
Merged
Destynova2 merged 2 commits intomainfrom Apr 25, 2026
Merged
fix(ci,openai): unbreak Docs Lint + bump rustls-webpki sec patch#261Destynova2 merged 2 commits intomainfrom
Destynova2 merged 2 commits intomainfrom
Conversation
added 2 commits
April 25, 2026 16:55
…chee --exclude-mail The Codex system prompt is a binary asset embedded via include_str!, not user documentation. Co-locating it next to its sole consumer (src/providers/openai/) restores the asset/doc boundary and naturally takes it out of the docs-lint scope, which was failing markdownlint on the verbatim upstream formatting (* lists, 4-space indent). Also drop --exclude-mail from the lychee step: the flag was removed in lychee v0.23.0 and was failing the broken-link job with 'unexpected argument'. No mailto links exist in the scoped files. Updated references in docs/reference/providers.md and ADR 0007.
Reachable panic in CRL parsing (BorrowedCertRevocationList::from_der / OwnedCertRevocationList::from_der mishandling an empty BIT STRING in the onlySomeReasons element of IssuingDistributionPoint). Pulled in transitively via reqwest -> rustls. Bumped via `cargo update -p rustls-webpki`. No source changes.
This was referenced Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex_instructions.mdfromdocs/reference/back tosrc/providers/openai/. It's a binary asset embedded viainclude_str!, not user docs — putting it underdocs/**(commit 9cf19ea, chore: release v0.20.1 #37) made markdownlint trip on the verbatim upstream Codex CLI formatting (*lists, 4-space indent), failing 20 lint errors. Co-locating it next to its sole consumer fixes the lint scope naturally and clarifies asset-vs-doc intent for contributors.--exclude-mailfrom the lychee step in.github/workflows/docs-lint.yml. The flag was removed in lychee v0.23.0 and was failing the broken-link job witherror: unexpected argument '--exclude-mail' found. No mailto links in the scoped files (docs/**/*.md,README.md,CLAUDE.md).rustls-webpki0.103.12 → 0.103.13 (RUSTSEC-2026-0104, reachable panic in CRL parsing). Pulled in transitively viareqwest → rustls. Required to keepCargo Denygreen — advisory was published after the last main CI pass, so this PR would otherwise inherit the breakage.References updated in
docs/reference/providers.mdanddocs/decisions/0007-openai-compat-dual-surface.md.Test plan
cargo check -p grob(verifies the newinclude_str!("./codex_instructions.md")path resolves)cargo nextest run --profile ci(pre-push hook)cargo deny check advisories→advisories okcargo fmt,cargo clippy --all-targets -- -D warnings,cargo audit,cargo machete, doc tests, doc coverage — all green via prek pre-push