fix(profiles): rename silently-ignored fields + wire Phase P in full-opti-v5#273
Merged
Destynova2 merged 1 commit intomainfrom Apr 25, 2026
Merged
fix(profiles): rename silently-ignored fields + wire Phase P in full-opti-v5#273Destynova2 merged 1 commit intomainfrom
Destynova2 merged 1 commit intomainfrom
Conversation
…opti-v5
The profile had five field names that serde silently ignored, falling
back to defaults. Discovered while wiring the Phase P SimHash threshold.
Renames (silent → operational):
- router.web_search → router.websearch
- cache.ttl_seconds → cache.ttl_secs
- cache.max_entries → cache.max_capacity
- budget.warning_threshold_percent → budget.warn_at_percent
- security.rate_limit_rpm → security.rate_limit_rps + rate_limit_burst
(2 rps + burst 30 ≈ 120 rpm sustained
with tolerance for parallel tool calls)
Phase P additions:
- cache.simhash_threshold = 4 (default 3, slightly more permissive
to favor hits on paraphrases without colliding unrelated prompts)
- cache.max_entry_bytes = 4 MiB (was unset, default 2 MiB)
- cache.max_capacity 1000 → 10000 (10x window, ~20 MiB total)
- cache.ttl_secs 3600 → 14400 (4h — covers a full Claude Code day)
Validation: `grob --config profiles/full-opti-v5.toml doctor` returns
"All checks passed" and prints `rate_limit=2rps`, confirming the
renames are now read by the parser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The `profiles/full-opti-v5.toml` profile had five field names that serde silently ignored, so the profile shipped with default values for those keys instead of the values written. Discovered while wiring the new Phase P SimHash threshold.
Renames (silently dropped → operational)
The security split keeps the same sustained rate (2 rps × 60 = 120 rpm) but adds a 30-request burst tolerance — Claude Code routinely fires 5–10 parallel tool calls in a single turn.
Phase P additions
Validation
```sh
grob --config profiles/full-opti-v5.toml doctor
```
returns `🎉 All checks passed!` and prints `rate_limit=2rps` — proof that the renamed field is now read by the parser (before this PR, the value was silently the default).
Test plan