[ENG-37265] refactor: remove default vertical scroll from list data table#541
Merged
robsongajunior merged 4 commits intomainfrom Apr 30, 2026
Merged
Conversation
8524658 to
3b78abb
Compare
gdsantana
approved these changes
Apr 29, 2026
robsongajunior
requested changes
Apr 29, 2026
Collaborator
|
🎉 This PR is included in version 1.27.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ListDataTabledefaults so it does not scroll internally by default:scrollablefromtruetofalse, andscrollHeightdefault removed (empty string).:scrollableand:scrollHeightto the underlyingPrimeDataTable(they were declared as props but not actually wired to the inner component, so callers couldn't enable scroll even when they tried).Root cause
The wrapper exposed
scrollable/scrollHeightprops but never bound them toPrimeDataTable. The defaults still suggested an internal scroll, leaving consumers in an inconsistent state.Changes
packages/webkit/src/core/list-data-table/components/list-data-table/list-data-table.vuescrollable: false,scrollHeight: '':scrollable="scrollable"and:scrollHeight="scrollable ? scrollHeight : ''"onPrimeDataTableTest plan
ListDataTable.stories.jsdefault story shows no internal scroll.:scrollable="true"on a story explicitly re-enables scroll (defaultscrollHeightno longer hidden).ListDataTableconsumers in storybook.