Skip to content

Add icons, messages, elapsed time to CLI progress bars#103

Merged
azriel91 merged 12 commits intomainfrom
feature/102/cli-progress-bar-improvements
Mar 20, 2023
Merged

Add icons, messages, elapsed time to CLI progress bars#103
azriel91 merged 12 commits intomainfrom
feature/102/cli-progress-bar-improvements

Conversation

@azriel91
Copy link
Copy Markdown
Owner

@azriel91 azriel91 commented Mar 20, 2023

Closes #102.

  • Add icons, messages, elapsed time to CLI progress bars
  • Send progress updates in app_cycle example item specs.
  • Tar X item spec does not include directories in FileMetadatas.

Before:

progress_bar_before

After:

progress_bar_after

@azriel91 azriel91 force-pushed the feature/102/cli-progress-bar-improvements branch from fc00214 to 5971c52 Compare March 20, 2023 04:30
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 20, 2023

Codecov Report

Patch coverage: 90.73% and project coverage change: +0.02 🎉

Comparison is base (52c2575) 93.47% compared to head (6284159) 93.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   93.47%   93.50%   +0.02%     
==========================================
  Files         274      274              
  Lines       19957    20155     +198     
==========================================
+ Hits        18654    18845     +191     
- Misses       1303     1310       +7     
Impacted Files Coverage Δ
crate/core/src/progress/progress_update.rs 100.00% <ø> (ø)
crate/core/src/progress/progress_update_and_id.rs 100.00% <ø> (ø)
item_specs/tar_x/src/tar_x_error.rs 0.00% <ø> (ø)
...tem_specs/tar_x/src/tar_x_state_current_fn_spec.rs 57.14% <15.78%> (-9.53%) ⬇️
...tem_specs/tar_x/src/tar_x_state_desired_fn_spec.rs 78.31% <66.66%> (-0.44%) ⬇️
crate/rt_model_native/src/output/cli_output.rs 84.90% <88.88%> (+3.52%) ⬆️
crate/rt/src/cmds/sub/apply_cmd.rs 81.02% <92.30%> (+0.89%) ⬆️
crate/core/src/progress/progress_msg_update.rs 100.00% <100.00%> (ø)
crate/core/src/progress/progress_sender.rs 100.00% <100.00%> (ø)
crate/core/src/progress/progress_tracker.rs 100.00% <100.00%> (ø)
... and 5 more

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@azriel91 azriel91 merged commit 3f45424 into main Mar 20, 2023
@azriel91 azriel91 deleted the feature/102/cli-progress-bar-improvements branch March 20, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve CLI progress bar user interface

1 participant