Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
==========================================
+ Coverage 89.21% 91.85% +2.63%
==========================================
Files 359 380 +21
Lines 32877 35539 +2662
==========================================
+ Hits 29332 32645 +3313
+ Misses 3545 2894 -651
☔ View full report in Codecov by Sentry. |
azriel91
force-pushed
the
maintenance/136/increase-coverage
branch
from
8928d2e to
ff30776
Compare
Regex replacement used in sublime text:
```regex
^ assert!\(
^ matches!([^;]+)
^ \);
```
replace:
```
({
#[cfg_attr(coverage_nightly, no_coverage)]
|| {
assert!(
matches!\1
);
}
})();
```
…riants." This reverts commit 3f42051.
We probably don't need the level of extraction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #136.
"output_colorized"feature, and always include colorized output."output_json"feature, and always include json output format.Rationale for feature removal is because we ran into GitHub Action runners' disk space limit. There wasn't very much value feature gating colorization and json, and it makes it easier to maintain fewer features as well. See taiki-e/cargo-llvm-cov#284.