Skip to content

Attempt at changing ItemId struct into a trait, and passing ItemIdT type parameter around.#181

Merged
azriel91 merged 7 commits intomainfrom
feature/158/enum-item-id
Feb 1, 2024
Merged

Attempt at changing ItemId struct into a trait, and passing ItemIdT type parameter around.#181
azriel91 merged 7 commits intomainfrom
feature/158/enum-item-id

Conversation

@azriel91
Copy link
Copy Markdown
Owner

@azriel91 azriel91 commented Feb 1, 2024

Closes #158.

This doesn't actually implement it -- the number of types that need the <ItemIdT> type parameter is large, and the API ergonomic hit, as well as framework maintenance is so costly that this approach is not desirable.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3683183) 93.85% compared to head (8edea31) 93.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage   93.85%   93.85%           
=======================================
  Files         407      407           
  Lines       41320    41320           
=======================================
  Hits        38780    38780           
  Misses       2540     2540           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azriel91 azriel91 merged commit 2bea066 into main Feb 1, 2024
@azriel91 azriel91 deleted the feature/158/enum-item-id branch February 1, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ItemId: API design

1 participant