Skip to content

Tidy up mapping function calls, and document mapping functions map design.#183

Merged
azriel91 merged 3 commits intomainfrom
feature/156/params-spec-mapping-fns-separate
Feb 3, 2024
Merged

Tidy up mapping function calls, and document mapping functions map design.#183
azriel91 merged 3 commits intomainfrom
feature/156/params-spec-mapping-fns-separate

Conversation

@azriel91
Copy link
Copy Markdown
Owner

@azriel91 azriel91 commented Feb 3, 2024

Closes #156.

This doesn't actually implement it, because the value of implementation switches a compilation error in the current behaviour, for a runtime error, and:

  • it's somewhat harder to track down
  • I couldn't turn it back into a compilation error

Sad part is automation developers have to specify the mapping functions twice.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2bea066) 93.85% compared to head (f11d199) 93.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #183   +/-   ##
=======================================
  Coverage   93.85%   93.85%           
=======================================
  Files         407      407           
  Lines       41320    41320           
=======================================
  Hits        38780    38780           
  Misses       2540     2540           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azriel91 azriel91 merged commit 9836dd3 into main Feb 3, 2024
@azriel91 azriel91 deleted the feature/156/params-spec-mapping-fns-separate branch February 3, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ParamsSpec: Store Mapping Functions Separately

1 participant