Skip to content

patch NC-03, L-12#5

Merged
dudong2 merged 2 commits intocanto-v8/developfrom
patch/issue-NC-03,L-12
Jul 12, 2024
Merged

patch NC-03, L-12#5
dudong2 merged 2 commits intocanto-v8/developfrom
patch/issue-NC-03,L-12

Conversation

@dudong2
Copy link
Member

@dudong2 dudong2 commented Jul 2, 2024

Closes: #XXX

Description

NC-03

Missing checks for implementing all interfaces

  • Added module interface check to x/<module name>/module.go

L-12

The protobuf strings are hardcoded

  • Replace inferface name from hardcoded "TxData" to "ethermint.evm.v1.TxData"

Closes: NC-03, L-12


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@dudong2 dudong2 self-assigned this Jul 2, 2024
@dudong2 dudong2 requested a review from poorphd July 2, 2024 08:07
Copy link
Collaborator

@poorphd poorphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 requested review from dongsam and zsystm July 9, 2024 14:49
Copy link
Collaborator

@zsystm zsystm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 merged commit 6fd4228 into canto-v8/develop Jul 12, 2024
@dudong2 dudong2 deleted the patch/issue-NC-03,L-12 branch July 12, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants