Skip to content

Fix: fix default home dir for client.toml#9

Merged
dudong2 merged 1 commit intocanto-v8/developfrom
patch/configclient
Jul 12, 2024
Merged

Fix: fix default home dir for client.toml#9
dudong2 merged 1 commit intocanto-v8/developfrom
patch/configclient

Conversation

@dudong2
Copy link
Member

@dudong2 dudong2 commented Jul 10, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@dudong2 dudong2 requested a review from poorphd July 10, 2024 14:23
@dudong2 dudong2 self-assigned this Jul 10, 2024
Copy link
Collaborator

@poorphd poorphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dudong2 dudong2 requested review from dongsam and zsystm July 11, 2024 09:34
Copy link
Collaborator

@zsystm zsystm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 merged commit da23458 into canto-v8/develop Jul 12, 2024
@dudong2 dudong2 deleted the patch/configclient branch July 12, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants