🚀 Turbo: Optimize WorldScene store subscription#89
Conversation
Optimized the `WorldScene.ts` store subscription by refactoring the `useGameStore.subscribe` callback. Implemented early returns and granular reference checks for settlements to avoid redundant rendering and expensive O(N) calculations. Replaced full-unit-list flattening with targeted `selectUnitById` calls to track selection state changes efficiently. These changes significantly reduce the overhead on the main thread during state updates.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
b0x1
deleted the
turbo-optimize-worldscene-subscription-10393871524877141450
branch
1 participant
Optimized the
WorldScene.tsstore subscription by refactoring theuseGameStore.subscribecallback. Implemented early returns, granular reference checks for settlements, and lazy flattening of settlement arrays. Replaced full-unit-list flattening with targetedselectUnitByIdcalls to track selection state changes efficiently. All tests passed, and frontend verification confirmed correct rendering and selection behavior.PR created automatically by Jules for task 10393871524877141450 started by @b0x1