[TASK] acceptance tests v12 #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
achimfritz
commented
Apr 14, 2023
achimfritz
commented
- TYPO3 v12 backend tests
- phpunit accessible mock builder
- phpunit use setMethods
- use dev-main branch for v12
* TYPO3 v12 backend tests * phpunit accessible mock builder * phpunit use setMethods * use dev-main branch for v12
bmack
approved these changes
Apr 18, 2023
lolli42
reviewed
Apr 18, 2023
| $containerGridColumnItem = $this->getAccessibleMock(ContainerGridColumnItem::class, ['foo'], [], '', false); | ||
| $containerGridColumnItem = $this->getMockBuilder($this->buildAccessibleProxy(ContainerGridColumnItem::class)) | ||
| ->disableOriginalConstructor() | ||
| ->addMethods(['foo']) |
Contributor
There was a problem hiding this comment.
note addMethods() has been deprecated with phpunit v10.1, we'll start removing it from core codebase soon. use onlyMethods([]) to say "don't mock-away anything".
Contributor
Author
There was a problem hiding this comment.
i will do a new PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.