[BUGFIX] enable recursive copy of multiple containers via DataHandler #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @DavidHedden , looks good, thanks, can you also write a functional test? |
Contributor
Author
|
Hi @achimfritz, i added a test were it's validated that the child records are in the correct container. |
DavidHedden
force-pushed
the
patch-1
branch
2 times, most recently
from
299b778 to
eae2b1f
Compare
Use copyMappingArray_merged instead of first key from $pasteDatamap, since it could include multiple id's
Contributor
Author
|
Fixed the formatting issues. Should've seen that there is a script for that. |
achimfritz
approved these changes
Mar 28, 2024
Contributor
achimfritz
left a comment
achimfritz
left a comment
There was a problem hiding this comment.
👍 , very cool, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
copyMappingArrayinstead of first key from$pasteDatamap, since it could include multiple id's.To clarify where this is a problem. When copying multiple containers via the data handler while using
'action' => 'paste'instead of a target. The$pasteDataMapprovided to the hook will not clear itself after performing each copy of a container. So the first provided container will be used as a target for all the child records.