!!! [TASK] Drag and Drop Refactoring in PageModule #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get rid of using combined colPos and tx_container_parent during drag and drop in BE PageModule regards TYPO3 >= 12 only we introduce a data-tx-container-parent data-attribute to the container-column div-container in the Grid/Column Partial and use patched JavaScript Files from core layout-module to send that attribute to the TYPO3 DataHandler Command Before we sent a combined colPos-tx_container_parent parameter as colPos and seperate the parameter in the DataHandler Hook the constant ContainerGridColumn::CONTAINER_COL_POS_DELIMITER_V12 is removed if you use own Grid/Column Partial you have to add the data-tx-container-parent to the div-container in your Partial Fixes: #456 Fixes: #464 Relates to: #443
bmack
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get rid of using combined colPos and tx_container_parent during drag and drop in BE PageModule
we introduce a data-tx-container-parent data-attribute to the container-column div-container in the Grid/Column Partial and use patched JavaScript Files from core layout-module to send that attribute to the TYPO3 DataHandler Command
Before we sent a combined colPos-tx_container_parent parameter as colPos and seperate the parameter in the DataHandler Hook
the constant ContainerGridColumn::CONTAINER_COL_POS_DELIMITER_V12 is removed
if you use own Grid/Column Partial you have to add the data-tx-container-parent to the div-container in your Partial
Fixes: #456
Fixes: #464
Relates to: #443